From c98c562bc910d093e6c1f7686033e551fd49ef5b Mon Sep 17 00:00:00 2001 From: Olof Larsson Date: Thu, 12 May 2016 07:27:12 +0200 Subject: [PATCH] BoardUtil - Missing NoChange Detection and TODO Comments. --- src/com/massivecraft/massivecore/util/BoardUtil.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/com/massivecraft/massivecore/util/BoardUtil.java b/src/com/massivecraft/massivecore/util/BoardUtil.java index 09f2fff3..81ad3430 100644 --- a/src/com/massivecraft/massivecore/util/BoardUtil.java +++ b/src/com/massivecraft/massivecore/util/BoardUtil.java @@ -802,11 +802,13 @@ public class BoardUtil extends Engine public static void addTeamMember(Team team, Object key) { + if (isTeamMember(team, key)) return; team.addEntry(getKey(key)); } public static void removeTeamMember(Team team, Object key) { + if ( ! isTeamMember(team, key)) return; team.removeEntry(getKey(key)); } @@ -855,6 +857,8 @@ public class BoardUtil extends Engine { Team before = getKeyTeam(board, key); if (MUtil.equals(before, team)) return; + // TODO: Do we really need to remove from the old team first? + // TODO: Chances are this would be done automatically. if (before != null) removeTeamMember(before, key); if (team != null) addTeamMember(team, key); }