If plugin failed to load correctly for various reasons, it could end up wiping the board or faction list. This should now be prevented.

An example: if you loaded 1.6.6 (not 1.6.6b) on CB 1.1-R6 or newer, it would trigger an exception at startup and cause this problem.

src/com/massivecraft/factions/P.java

@@ -78,6 +78,7 @@ public class P extends MPlugin
 	public void onEnable()
 	{
 		if ( ! preEnable()) return;
+		this.loadSuccessful = false;
 
 		// Load Conf from disk
 		Conf.load();
@@ -112,6 +113,7 @@ public class P extends MPlugin
 		getServer().getPluginManager().registerEvents(serverListener, this);
 
 		postEnable();
+		this.loadSuccessful = true;
 	}
 	
 	@Override
@@ -132,9 +134,13 @@ public class P extends MPlugin
 
 	@Override
 	public void onDisable()
+	{
+		// only save data if plugin actually completely loaded successfully
+		if (this.loadSuccessful)
 		{
 			Board.save();
 			Conf.save();
+		}
 		EssentialsFeatures.unhookChat();
 		if (AutoLeaveTask != null)
 		{

src/com/massivecraft/factions/zcore/MPlugin.java

@@ -34,6 +34,7 @@ public abstract class MPlugin extends JavaPlugin
 	public Gson gson;	
 	private Integer saveTask = null;
 	private boolean autoSave = true;
+	protected boolean loadSuccessful = false;
 	public boolean getAutoSave() {return this.autoSave;}
 	public void setAutoSave(boolean val) {this.autoSave = val;}
 	
@@ -82,6 +83,7 @@ public abstract class MPlugin extends JavaPlugin
 			saveTask = Bukkit.getServer().getScheduler().scheduleSyncRepeatingTask(this, new SaveTask(this), saveTicks, saveTicks);
 		}
 
+		loadSuccessful = true;
 		return true;
 	}
 	
@@ -97,6 +99,8 @@ public abstract class MPlugin extends JavaPlugin
 			this.getServer().getScheduler().cancelTask(saveTask);
 			saveTask = null;
 		}
+		// only save data if plugin actually loaded successfully
+		if (loadSuccessful)
 			EM.saveAllToDisc();
 		log("Disabled");
 	}