Rx3/MassiveCore
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Catch Throwable instead of Exception for NMS activate auto. Fixes #304.

Browse Source
This commit is contained in:
Olof Larsson 2017-07-02 15:58:51 +02:00
parent 65fa8de0f7
commit 0e4c5d7ee4
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/com/massivecraft/massivecore/MassivePlugin.java
View File

@ -360,8 +360,16 @@ public abstract class MassivePlugin extends JavaPlugin implements Listener, Name
ReflectionUtil.getField(clazz, "d"); ReflectionUtil.getField(clazz, "d");
return true; return true;
} }
catch (Exception ex) catch (Throwable throwable)
{ {
// We need to catch throwable here.
// NoClassDefFoundError will happen for NmsMixins targeting incompatible versions.
// On Minecraft 1.8 we did for example get this error:
// > java.lang.NoClassDefFoundError: org/bukkit/scoreboard/Team$Option
// > at java.lang.Class.getDeclaredFields0(Native Method) ~[?:1.8.0_111]
// > at java.lang.Class.privateGetDeclaredFields(Class.java:2583) ~[?:1.8.0_111]
// > at java.lang.Class.getDeclaredField(Class.java:2068) ~[?:1.8.0_111]
// The Java reflection itself is simply not careful enough.
return false; return false;
} }
} }